Permit specifying output file #9640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For get* CLI switches
tmds
reviewed
Jan 18, 2024
tmds
reviewed
Jan 18, 2024
JanKrivanek
approved these changes
Feb 2, 2024
|
Looking forward to have this in an SDK near me! |
ladipro
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Looks good but this should not be merged without test coverage. Please add a test.
Also, ideally the new command line switch would be added to -help output but -getProperty and such are still missing from it so we can handle it as part of #9710.
added 2 commits
February 23, 2024 06:36
…d/msbuild into add-output-to-file-option
|
FYI, I called my commit 'Start on test', but that was just because I don't have the components to build on this laptop, so I didn't run it locally before pushing, but it seems to have built and passed 🙂 |
|
@Forgind is this a .NET 9 feature only? Or is it expected to become available in a .NET 8 SDK band? |
|
@tmds it'll be in MSBuild 17.10/SDK 8.0.3xx. |
|
Good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For get* CLI switches
Fixes #
Context
Design question:
Should SimpleErrorLogger be enabled if we're redirecting into a file? Should it be enabled whenever we aren't using TerminalLogger?
The reason I ask is that it's the only thing that writes to stderr at the moment, so since I re-enabled normal loggers when writing to a file, that means I disabled SimpleErrorLogger, and now errors come through stdout (with no TerminalLogger) as MSBuild normally does things. I'm not convinced that's ideal...
Changes Made
Permit using -getResultOutputFile to redirect output from get* into a file. Example:
dotnet msbuild foo.csproj -getProperty:Bar -getResultOutputFile:Biz.txt
This writes the value of property Bar into Biz.txt.
Testing
I tried using this, and it failed to load my test project because it was trying to include $(MonoAndroidResourcePrefix)(various), and MonoAndroidResourcePrefix was not defined. That doesn't feel like it's related to my change, but it's hard for me to firmly state that this works when 100% of my tests have failed 🙃I tried again today, and the error mysteriously disappeared. It failed until I added Flush, but now it seems to work properly.
Notes