Add missing query CleanupDefunctSiloEntriesKey to SQLServer clusterin… #8811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-arias
added a commit
to juan-arias/orleans
that referenced
this pull request
Feb 1, 2024
This is the same issue described in dotnet#8676 but for MySQL. This PR will update it in a similar way as dotnet#8811
…https://github.com/m3nax/dotnet-orleans into fix/add-missing-query-in-sqlserver-clustering-script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g script
Problem:
As written in the issue #8676 and docs, to set up ADO.NET clustering using the SQLServer you need to run 2 scripts in sequence:
However, the clustering script does not include the creation of the
CleanupDefunctSiloEntriesKeyquery required by the ADO.NET implementation (Microsoft.Orleans.Clustering.AdoNet) in both the 7.2.x and the 8.0.x versions of Orleans.Missing query causes an exception at program startup.
Proposed solution:
Add the missing query to clustering sql script.
Ref:
Microsoft Reviewers: Open in CodeFlow