Add Microsoft.Extensions.Configuration provider for azure queue streaming #8929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskimmett
commented
Mar 31, 2024
| { | ||
| public void Configure(ISiloBuilder builder, string name, IConfigurationSection configurationSection) | ||
| { | ||
| builder.AddAzureQueueStreams(name, (OptionsBuilder<AzureQueueOptions> optionsBuilder) => |
There was a problem hiding this comment.
I wasn't sure if this also needs to support configuring the MessageVisibilityTimeout. I can get that added in if so.
|
@benjaminpetit PTAL - what should IConfiguration support look like for Azure Queues @tskimmett a test would be helpful here. Eg, update some/all of the existing Azure Queue Streaming tests to use this functionality. |
ReubenBond
changed the title
|
I looked to see if there were relevant tests that could be updated for this and couldn't really tell, but I can take another look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in using Aspire with an Orleans project I'm working on which uses Azure storage for persistence/streaming, but I saw Orleans doesn't yet support the streaming config sent over by the Aspire apphost. I based my changes off of #8764 and did some pretty minimal manual testing using the orleans sample in the Aspire playground.
Microsoft Reviewers: Open in CodeFlow