Brings back support for StringData in ATS provider
#8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pic of it in action
|
src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureTableStorageOptions.cs
Outdated
Show resolved
Hide resolved
| @@ -202,23 +203,29 @@ private static async Task DoOptimisticUpdate(Func<Task> updateOperation, string | |||
| /// </remarks> | |||
| internal void ConvertToStorageFormat<T>(T grainState, TableEntity entity) | |||
There was a problem hiding this comment.
It would be great to add a test to check the behavior of the new option
|
I'll address both points |
added 2 commits
May 19, 2024 00:10
…check if 'UseStringFormat' works correctly.
|
@benjaminpetit i've addressed both points, sorry for the delay! Have a look at the test specifically the comment I left, let me know if my reasoning makes sense to you. |
benjaminpetit
approved these changes
May 23, 2024
|
@ReubenBond it would be awesome if this could be merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Azure Table Storage provider saves the grain state (encoded JSON) but in binary format- Regardless if the orleans serializer or one of the two json serializer are used. And while it can be decoded as UTF-8, its cumbersome to do that when someone wants to manually intervene and change the data in ATS. Let alone just a quick way to simply look at the data.
This PR brings back
StringDatabut with the difference that its does NOT useNewtonsoft.Jsonto serialize the data as it was previously, but instead uses theGrainStorageSerializerand converts theBinaryDatato a string format. This allows the data to follow what ever grain storage serializer is configured by the user i.e.: Newtonsoft.JsonorSystem.Text.Json`.AFAIK this is not a breaking change, as we'll continue to read both formats for backwards compatibility.
Microsoft Reviewers: Open in CodeFlow