Exclude explicitly implemented interface methods from proxy #8992
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrz
commented
May 10, 2024
| @@ -81,7 +81,12 @@ private List<ProxyMethodDescription> GetMethods(INamedTypeSymbol symbol) | |||
| { | |||
| foreach (var method in iface.GetDeclaredInstanceMembers<IMethodSymbol>()) | |||
| { | |||
| if (methods.TryGetValue(method, out _)) | |||
| if (method.MethodKind == MethodKind.ExplicitInterfaceImplementation) | |||
There was a problem hiding this comment.
I think this should also check for a body, explicit impls can be used for reabstraction in interface type hierarchies.
There was a problem hiding this comment.
I am not sure it's necessary: the generated proxy should implement every method explicitly (I added a comment below this line). Any overrides should take effect on the callee side naturally (correct me if you find that I'm wrong here)
|
What sort of tests do we need here? I'd appreciate some pointers on existing unit tests so I can follow from there. Also not sure about namings and the location these interfaces should be declared in. @ReubenBond for review, thanks. |
|
I fixed the merge conflict. LGTM. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8991
Microsoft Reviewers: Open in CodeFlow