Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pinned pkcs entry #73515

Merged
merged 2 commits into from
May 17, 2024
Merged

Add a pinned pkcs entry #73515

merged 2 commits into from
May 17, 2024

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner May 16, 2024 18:40
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 16, 2024
@marcpopMSFT marcpopMSFT mentioned this pull request May 16, 2024
Merged
@ericstj
Copy link
Member

ericstj commented May 16, 2024

CC @jjonescz and @sharwell since this was added in #72242. I think this is correct regardless. Since that reference of XML will bring in the out-of-date Pkcs, they both should be updated.

Please double check that the branch is open for these types of check-ins before merging.

@marcpopMSFT
Copy link
Member Author

@MichaelSimons @mthalman do I need to go update SBRP for this package now?

@mthalman
Copy link
Member

@MichaelSimons @mthalman do I need to go update SBRP for this package now?

Yes. Does it need to be 7.0.3? We already have 7.0.2 in SBRP.

@marcpopMSFT
Copy link
Member Author

Good suggestion. 7.0.2 appears to be new enough to not have known issues so let me try that one. I went to 7.0.3 simply because that was the latest one.

@jaredpar jaredpar merged commit 9b0d56d into dotnet:release/dev17.10 May 17, 2024
24 of 30 checks passed
@baronfel baronfel mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcpopMSFT @ericstj @mthalman @jaredpar