Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete UseWindowsThreadpool special casing #101591

Open
MichalStrehovsky opened this issue Apr 26, 2024 · 1 comment
Open

Delete UseWindowsThreadpool special casing #101591

MichalStrehovsky opened this issue Apr 26, 2024 · 1 comment
Labels
area-NativeAOT-coreclr blocked Issue/PR is blocked on something - see comments
Milestone
9.0.0

Comments

@MichalStrehovsky
Copy link
Member

Delete this line:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Line 293 in a45853c

<IlcArg Condition="'$(UseWindowsThreadPool)' != '' and '$(_targetOS)' == 'win'" Include="--feature:System.Threading.ThreadPool.UseWindowsThreadPool=$(UseWindowsThreadPool)" />

Once repo starts building with SDK that has this: dotnet/sdk#40372

Probably Preview 5+.

Also search for this issue number for other things to undo.
@MichalStrehovsky MichalStrehovsky added blocked Issue/PR is blocked on something - see comments area-NativeAOT-coreclr labels Apr 26, 2024
@MichalStrehovsky MichalStrehovsky added this to the 9.0.0 milestone Apr 26, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NativeAOT-coreclr blocked Issue/PR is blocked on something - see comments
Projects
AppModel
Status: No status
Milestone
9.0.0
Development

No branches or pull requests
1 participant
@MichalStrehovsky