Merge JIT/Methodical tests into the merged runners #101317
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jkoritzinsky
force-pushed
the
methodical-merge-csproj
branch
from
39796e2
to
c646f6a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This cuts about a minute off of the managed test builds. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Removing the extra test group used for building in Pri1, this now saves 4 minutes in a Pri1 build (comparing the run in the PR and a run against main). |
| @@ -670,7 +670,8 @@ private static int f109(int x, int y) | |||
|
|
|||
|
|
|||
| [Fact] | |||
| public static int TestEntryPoint() | |||
| [OuterLoop] | |||
There was a problem hiding this comment.
The indentation got a bit messed up here
There was a problem hiding this comment.
Yeah some of these tests had really weird indentation to start with. I'll see if I can normalize it.
|
From what I'm seeing here, plus that the pipelines came back clean, it looks good to me! I think we should write a doc explaining how the new tags you added like |
|
/ba-g timeouts unrelated (the mono interpreter leg timed out before any tests even started to run) |
This PR merges many of the tests in the JIT/Methodical tree into their respective merged runners. This was done using the following process:
<CLRTestPriority>1</CLRTestPriority>to[Outerloop].<GCStressIncompatible>true</GCStressIncompatible>to[SkipOnCoreClr(RuntimeTestMode.AnyGCStress)]<JitOptimizationSensitive>true</JitOptimizationSensitive>to[SkipOnCoreClr(RuntimeTestMode.AnyJitStress)]<HeapVerifyIncompatible>true</HeapVerifyIncompatible>to[SkipOnCoreClr(RuntimeTestMode.HeapVerify)]<RequiresProcessIsolation>true</RequiresProcessIsolation>that was only there to support the above properties.<Compile />entries for tests that are not<RequiresProcessIsolation>true</RequiresProcessIsolation>into the corresponding merged runner..csprojprojects.A few tests were left with their csproj files intact as they include the same test source with different type definitions to reuse test code and merging them into the same assembly causes significant test size increase (ie. 30k line delta, +15k lines)
With this change, we remove ~1100 csproj files from the test tree (of 6982 csproj files today).