Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #92296 to release/8.0-staging #101627

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Apr 26, 2024

This is part of the work to transition to the 1ES templates in servicing branches.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2440254&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

@eduardo-vp eduardo-vp changed the base branch from main to release/8.0-staging April 26, 2024 20:51
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

…t#92296)

* Build the PGO build legs through the global build job template.

* Remove pgoType parameters and plumbing from all jobs and use the -pgoinstrument flag instead of setting the property manually.

* Limit subsets to build to limit packages and don't build crossgen2 sfxproj for internal optimization pipelines (we don't use it).

* Fix job dependencies now that the non-global jobs don't have PGO type in the name

* Change back to the triple-underscore name

* Fix Mono artifacts to not have an extra underscore for PGO scenarios.

* There's an extra underscore for the CoreCLR artifacts because there's no runtime variant.
@eduardo-vp eduardo-vp force-pushed the backport-92296-to-release-8.0-staging branch from eea3358 to d82b8d3 Compare April 28, 2024 22:08
@eduardo-vp eduardo-vp changed the title [Testing] Backport #92296 and #92901 to release/8.0-staging [Testing] Backport #92296 to release/8.0-staging Apr 29, 2024
@eduardo-vp eduardo-vp changed the title [Testing] Backport #92296 to release/8.0-staging Backport #92296 to release/8.0-staging Apr 29, 2024
@eduardo-vp eduardo-vp marked this pull request as ready for review April 29, 2024 19:43
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified assets in the official build are right.

@jkoritzinsky jkoritzinsky added the Servicing-consider Issue for next servicing release review label Apr 29, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can treat this as tell mode.

cc @carlossanlop

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 30, 2024
@carlossanlop carlossanlop merged commit ec346c0 into dotnet:release/8.0-staging Apr 30, 2024
176 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants