Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for primary constructors in LoggerMessageGenerator #101660

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support for primary constructors in LoggerMessageGenerator #101660

wants to merge 9 commits into from
+533 −33

Commits on Apr 28, 2024

  1. Add support for primary constructors in LoggerMessageGenerator

    @kimsey0
    kimsey0 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d7497fc View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Get the primary constructor parameters types from the constructor sym… 

    …bol instead of from the semantic model
    @kimsey0
    kimsey0 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    15643ec View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Prioritize fields over primary constructor parameters and ignore shad… 

    …owed parameters when finding a logger
    @kimsey0
    kimsey0 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    9fc6ce4 View commit details
    Browse the repository at this point in the history

  2. Make checking for primary constructors non-conditional on Roslyn vers… 

    …ion and simplify project setup
    @kimsey0
    kimsey0 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2d6748c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Reintroduce Roslyn 4.8 test project

    @kimsey0
    kimsey0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6a8b473 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Add info-level diagnostic for logger primary constructor parameters t… 

    …hat are shadowed by field
    @kimsey0
    kimsey0 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6cf2b2f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Update list of diagnostics with new logging message generator diagnostic

    @kimsey0
    kimsey0 committed May 27, 2024
    Configuration menu
    Copy the full SHA
    69a5c00 View commit details
    Browse the repository at this point in the history

  2. Only add non-logger field names to set of shadowed names

    @kimsey0
    kimsey0 committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e029d54 View commit details
    Browse the repository at this point in the history

  3. Add comment explaining the use of the set of shadowed names with an e… 

    …xample
    @kimsey0
    kimsey0 committed May 27, 2024
    Configuration menu
    Copy the full SHA
    fd480f2 View commit details
    Browse the repository at this point in the history