Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Transition to 1ES templates work (Backport crossgen2 changes) #101869

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented May 4, 2024

This is part of the work to transition to the 1ES templates in servicing branches.

These crossgen2 changes are required to eventually backport #92901.

Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp
Copy link
Member Author

…e packs for all possible targets.


Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build.

Extracted from dotnet#92826
@eduardo-vp
Copy link
Member Author

eduardo-vp commented May 6, 2024

@agocke
Copy link
Member

agocke commented May 9, 2024

Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes.

@jkoritzinsky
Copy link
Member

The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported).

The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems.

@agocke
Copy link
Member

agocke commented May 9, 2024

Makes sense. I will review to try to ensure that all the pieces we've changed are backported.

@eduardo-vp
Copy link
Member Author

I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results)

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label May 10, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's consider this tell mode. please merge when ready

cc @carlossanlop

@eduardo-vp eduardo-vp added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 10, 2024
@eduardo-vp eduardo-vp merged commit 0fdb133 into dotnet:release/8.0-staging May 10, 2024
184 of 188 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants