Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-preview4] disable new EH on win-arm64 #102060

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2024

Backport of #102052 to release/9.0-preview4

/cc @mangod9

Customer Impact

  • Customer reported
  • Found internally

Some sdk commands are failing on windows arm64 due to effects of new Exception Handling. This appears to be a new issue in preview4 so disabling it on this platform.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

This was found based on SDK validation, also manually validated that disabling it resolves the issue on a windows arm64 VM.

Risk

Low, just falls back to previous exception handling. Note that new mechanism was only enabled in Preview3.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label May 10, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone May 10, 2024
@jeffschwMSFT jeffschwMSFT merged commit 2270e31 into release/9.0-preview4 May 10, 2024
93 of 98 checks passed
@mangod9 mangod9 deleted the backport/pr-102052-to-release/9.0-preview4 branch May 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants