-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Avoid membarrier on lower Android versions #93096
Conversation
Hopefully fixes #92196. I don't actually have an ARM64 device with an old Android version so I can't testing it actually fixes the problem, but it's a plausible fix.
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #92686 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #92686 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
Test failure is unrelated (Windows). I opened an issue: #93372 |
Backport of #92686 to release/8.0
/cc @MichalStrehovsky
Customer Impact
In .NET 8 we have experimental Android Bionic support for Native AOT. Customer found out there is an issue on Android 8.0 and 9.0 that makes Native AOT apps crash immediately at startup. This is because an API we can optionally use became unavailable in Android 8.0 and then became available again in Android 10.0.
Android 8+9 represents about 6% of the addressable market share and will likely prevent adoption of Native AOT.
Testing
Tested on an old tablet that matches the problematic specs. Verified the problem goes away.
Risk
Low, this is introducing an Android specific code path that prevents a crash (an
if
version check before calling the crashing API).Similar check exists in the Android ART runtime.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.