[release/8.0] Handle binding to initialized abstract members #93120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
If an abstract member is encountered in an object graph we should only throw if it's not already initialized.
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #93090 to release/8.0 /cc @ericstj Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
tarekgh
approved these changes
Oct 6, 2023
|
@artl93 can you please have a look? |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93090 to release/8.0
/cc @ericstj
Customer Impact
Cannot bind to abstract types when using the ConfigurationBinder source generator.
When binding to types which contain pre-initialized abstract members the ConfigurationBinder source generator will throw an exception, whereas the reflection-based binder will not. The generator also emits a diagnostic in this case.
We keep the diagnostic because the source generator cannot guarantee that the member will be pre-initialized, but the generator will emit code that uses the pre-initialized value for binding if present.
Testing
Tested real world application to confirm the fix. Added unit tests to cover new behavior.
Risk
There is still a discrepancy with the runtime binder, which is able to see the runtime type. I've filed #93130 to track that discrepancy. TLDR: we bind against the reference type only and not runtime type.