[release/8.0] Fix a memory leak in runtime interop stubs when using an array of structs of types that use old-style managed marshalers #93150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jkoritzinsky
changed the title
jeffschwMSFT
approved these changes
Oct 6, 2023
jeffschwMSFT
added
Servicing-approved
…n array of structs of types that use old-style managed marshalers
github-actions
bot
force-pushed
the
backport/pr-93147-to-release/8.0
branch
from
9b80bde
to
325eb62
Compare
jkotas
approved these changes
Oct 9, 2023
|
This PR is ready to be merged by someone who is authorized (I don't have authorization). |
That would be me @jkoritzinsky . Feel free to ping me via Teams if you'd like me to merge a PR that is ready. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93089 to release/8.0
/cc @jkoritzinsky
Description
When passing an array of structs that contains an array field marshalled as a SAFEARRAY or "ByValArray" field to a P/Invoke or a COM interop call, the native array and its contents are not released. This PR changes the marshalling logic such that the native array and contents will be released when they should be.
Customer Impact
Customers without this fix that have interop code with this shape will have unmanaged memory leaks.
Regression
This is a regression that was introduced in .NET 5.
Testing
This fix has been manually validated in main and a unit test has been added to the PR in main. This fix has also manually been validated in the 6.0 branch with the customer and it fixes their scenario.
Risk
The risk for this PR is low. The logic here will only be hit in these two scenarios, and the expected and documented behavior is that we do not leak this memory. It is very unlikely that customers have taken a dependency on this memory being leaked.