[release/8.0] Make a copy of assembly path. #93253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AaronRobinsonMSFT
added
the
Servicing-consider
jkotas
approved these changes
Oct 9, 2023
|
Will this make it into .NET 8 RC2? #93127 is tagged "blocking-release" but this is not tagged "servicing-approved". |
jeffschwMSFT
approved these changes
Oct 10, 2023
This will not be in RC2, but should be in the official release. |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93238 to release/8.0
/cc @AaronRobinsonMSFT
Customer Impact
Customer reported issue in #93127. When the Emit PerfMap feature is enabled, the
Assembly.Locationproperty can become corrupted. This was missed in a previous 8.0 fix, #91085.Testing
Validated the code path makes a copy and no longer permutes the one that backs the
Assembly.Locationproperty.Risk
Low. The only potential issue here is there could be other cases that are missed.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.