[release/8.0] [android][ios] Fix dispose problem with NativeHttpHandlers (#93262) #93291
Conversation
) dotnet#90298 made sure the MetricsHandler was the top level handler for all NativeHttpHandler requests similar to what is done with SocketsHttpHandler. After creating the MetricsHandler, the code mistakenly disposed of `_nativeHandler`, which resulted in `Dispose` being called multiple times and eventually throwing a `Cannot access a disposed object` exception. Fixes dotnet#93252
steveisok
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #93262 to release/8.0 /cc @steveisok Customer ImpactTestingRiskLow
|
steveisok
changed the title
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #93262 to release/8.0 /cc @steveisok Customer Impact#93252 identified a regression in The fix was to avoid disposing of the underlying native handler prematurely. TestingTested a patched SDK locally against a MAUI app that made multiple requests. RiskLow
|
steveisok
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Backport of #93262 to release/8.0
/cc @steveisok
Fixes #93252
Customer Impact
#93252 identified a regression in
HttpClientHandleron mobile where repeat requests would prematurely dispose the underlying native http handler. This leads to callingDisposemore than once and the runtime will throwCannot access a disposed objectand terminate the requests.The fix was to avoid disposing of the underlying native handler prematurely.
Testing
Tested a patched SDK locally against a MAUI app that made multiple requests.
Risk
Low