-
Notifications
You must be signed in to change notification settings - Fork 5k
[release/8.0] Adjust System.Net metrics for OTel conformance and consistency #93414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Adjust System.Net metrics for OTel conformance and consistency #93414
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAdjust System.Net metrics for OTel conformance and consistencyFixes #92956, fixes #92917, fixes #92837, fixes #93302 Backport of PRs #93255, #93254, #93322 Customer ImpactOpenTelemetry metrics is a new feature in .NET 8.0. TestingTarget test cases were added. RiskLow. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #92956, fixes #92917, fixes #92837, fixes #93302 Backport of PRs #93255, #93254, #93322 Customer ImpactOpenTelemetry metrics is a new feature in .NET 8.0. TestingTarget test cases were added. RiskLow. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Approved by Tactics via email. |
The CI failures are unrelated. |
Fixes #92956, fixes #92917, fixes #92837, fixes #93302
Backport of PRs #93255, #93254, #93322
Customer Impact
OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.
Testing
Target test cases were added.
Risk
Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.