[release/8.0] Ensure Parallel.ForAsync unregisters from CancellationToken #93674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @mangod9 Issue DetailsBackport of #93672 to release/8.0 /cc @stephentoub Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
MihaZupan
approved these changes
Oct 18, 2023
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93672 to release/8.0
/cc @stephentoub
Customer Impact
An infinite memory leak as long as the developer is reusing the same CancellationTokenSource. If they drop the CTS, then all the state it was keeping alive also goes away.
Testing
All existing tests continue to pass. It’s challenging to write a unit test for this specific functionality and fix, as the storage for this information isn’t observable via public surface area. However, it was validated using a derivation of the original supplied repo. Before the fix, memory usage keeps going up and up; after the fix, it remains steady.
Risk
Minimal risk, this only adds a call to Dispose at the right location.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.