[release/8.0] JIT: remove incorrect type deduction for an Unsafe.As case #93703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Thanks to @SingleAccretion for the fix. The JIT was assuming that an indirectly accessed value type field had the type of the field, but that might not be the case if the field was accessed via `Unsafe.As`. Fix this by limiting type deduction from these indirectly accessed fields to only ref type fields. Closes #93650.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #93694 to release/8.0 /cc @AndyAyersMS Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@jakobbotsch PTAL Would like to consider this for .NET 8. |
jakobbotsch
approved these changes
Oct 18, 2023
jeffschwMSFT
approved these changes
Oct 19, 2023
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
added
Servicing-approved
|
Failure unrelated - test timeout: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93694 to release/8.0
/cc @AndyAyersMS
Customer Impact
Regression from prior releases, reported by @pentp in #93650.
In some uncommon cases using
Unsafe.Ason a reference to a value class struct field, the JIT may use the type of the field as the type, instead of the cast-to type.Testing
Verified repro case is now fixed, no diffs in SPMI.
Risk
Low. This is a fairly surgical fix and makes the JIT more conservative.