Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Update dependencies from dotnet/arcade #93727

Merged
merged 4 commits into from
Oct 20, 2023
Merged

[release/8.0] Update dependencies from dotnet/arcade #93727

merged 4 commits into from
Oct 20, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 19, 2023 •
edited

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 2fb9f077-51f0-474b-0ead-08db9e40a4f0
  • Build: 20231016.4
  • Date Produced: October 16, 2023 7:28:01 PM UTC
  • Commit: 39042b4048580366d35a7c1c4f4ce8fc0dbea4b4
  • Branch: refs/heads/release/8.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
aba1aeb 
…016.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23505.1 -> To Version 8.0.0-beta.23516.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Oct 19, 2023
@build-analysis build-analysis bot mentioned this pull request Oct 19, 2023
Open
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Oct 19, 2023
@carlossanlop
Copy link
Member

@radical @lewing @steveisok - The wasm build failure is new in this PR and I was able to repro it consistently: it showed up again after a couple of retries. Can you please take a look?

  • Output:
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : The command could not be loaded, possibly because: [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :   * You intended to execute a .NET application: [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :       The application '--version' does not exist. [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :   * You intended to execute a .NET SDK command: [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :       A compatible .NET SDK was not found. [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :  [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : Requested SDK version: 8.0.100-rtm.23506.1 [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : global.json file: /__w/1/s/global.json [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :  [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : Installed SDKs: [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :  [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : Install the [8.0.100-rtm.23506.1] .NET SDK or update [/__w/1/s/global.json] to match an installed SDK. [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error :  [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : Learn about SDK resolution: [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : https://aka.ms/dotnet/sdk-not-found [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error : 8.0.100-rtm.23478.7 [/__w/1/s/artifacts/bin/dotnet-none/sdk] [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
/__w/1/s/eng/testing/workloads-testing.targets(98,5): error MSB3073: The command "/__w/1/s/artifacts/bin/dotnet-none/dotnet --version" exited with code 145. [/__w/1/s/src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj]
    0 Warning(s)
    17 Error(s)

lewing
lewing reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MicrosoftDotnetSdkInternalVersion needs to be greater than the sdk in global.json or unset

This was referenced Oct 20, 2023
Closed
Open
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
1584544 
…016.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23505.1 -> To Version 8.0.0-beta.23516.4
@carlossanlop
Copy link
Member

@lewing a new set of failures are showing up now. Can you please take a look?:

 Wasm.Build.Tests.Blazor.MiscTests3.WithDllImportInMainAssembly(config: "Debug", build: True, publish: False) [FAIL]
System.IO.DirectoryNotFoundException : Could not find a part of the path '/root/helix/work/workitem/e/wbt/blz_dllimp_Debug_煉build/Components/Pages/MyDllImport.cs'.
``

@lewing lewing requested a review from radical as a code owner October 20, 2023 17:57
@lewing
Copy link
Member

lewing commented Oct 20, 2023

blazor made some post rc1 template changes hopefully this is all the places

@lewing
Copy link
Member

lewing commented Oct 20, 2023

The same thing will probably eventually flow through 9.0.x so if you see something like that let me know.

@ViktorHofer ViktorHofer merged commit 07f535a into release/8.0 Oct 20, 2023
189 checks passed
@ViktorHofer ViktorHofer deleted the darc-release/8.0-18460c53-65f6-427b-941c-d1bc872f7629 branch October 20, 2023 20:11
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing left review comments

@radical radical radical approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlossanlop @lewing @radical @ViktorHofer