Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [iOS][non-icu] HybridGlobalization Get available locales #93751

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 19, 2023

Backport of #93594 to release/8.0

/cc @steveisok @mkhamoyan

Customer Impact

A customer reported #93514 where CultureInfo.GetCultures always returned an empty array when hybrid globalization was enabled. Hybrid globalization is a new opt-in feature where we rely on some native iOS API’s in order to reduce our dependence on ICU. In this case, it appears that when we changed our ICU filter to reduce the data we carry, we missed needing to make this native API call.
 
The fix was to call into the proper iOS API to get all the available locales on the device.

Testing

We added two new automated tests to validate the calls to GetCultures returns more than 0 elements.

Risk

Low
IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Oct 19, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93594 to release/8.0

/cc @steveisok @mkhamoyan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@tarekgh tarekgh added the os-ios Apple iOS label Oct 19, 2023
@ghost
Copy link

ghost commented Oct 19, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93594 to release/8.0

/cc @steveisok @mkhamoyan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Globalization, os-ios

Milestone: -

@carlossanlop
Copy link
Member

When ready, please send an email to Tactics requesting approval. Friendly reminder that we need this merged before 4pm tomorrow Friday 20th to ensure it goes into GA.

@steveisok steveisok added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 20, 2023
@steveisok
Copy link
Member

Approved over email by tactics.

@carlossanlop
Copy link
Member

That ios leg is taking forever to finish... and I'm waiting for it since it looks relevant to this change.

@steveisok
Copy link
Member

That ios leg is taking forever to finish... and I'm waiting for it since it looks relevant to this change.

It timed out. That tells me the helix queue is really backed up. The tvOS leg passed, so that is a good enough validation for me.

@carlossanlop
Copy link
Member

The tvOS leg passed, so that is a good enough validation for me.

:shipit:

@carlossanlop carlossanlop merged commit 4135a75 into release/8.0 Oct 20, 2023
182 of 191 checks passed
@carlossanlop carlossanlop deleted the backport/pr-93594-to-release/8.0 branch October 20, 2023 22:58
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Globalization os-ios Apple iOS Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants