Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [Test Only] Fix options source gen test #93782

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 20, 2023

Backport of #93709 to release/8.0

/cc @tarekgh

Customer Impact

Android tests are failing in CI.

Testing

The fix here is actually fixing the failing test.

Risk

None

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Oct 20, 2023

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93709 to release/8.0

/cc @tarekgh

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Extensions-Options

Milestone: -

@tarekgh tarekgh added the Servicing-consider Issue for next servicing release review label Oct 20, 2023
@tarekgh tarekgh changed the title [release/8.0] Fix options source gen test [release/8.0] [Test Only] Fix options source gen test Oct 20, 2023
@tarekgh tarekgh added this to the 8.0.0 milestone Oct 20, 2023
@ericstj ericstj added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 20, 2023
@ericstj
Copy link
Member

ericstj commented Oct 20, 2023

Tests are tell-mode. Just send mail to tactics mentioning the test only change.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode. Approved.

@carlossanlop carlossanlop merged commit cea93b5 into release/8.0 Oct 20, 2023
107 of 113 checks passed
@carlossanlop carlossanlop deleted the backport/pr-93709-to-release/8.0 branch October 20, 2023 20:25
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Options Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants