Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update dependencies from dotnet/emsdk #93801

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/emsdk

  • Subscription: 4ebef09c-22a4-4345-9e95-08db9f47cad7
  • Build: 20231020.2
  • Date Produced: October 20, 2023 6:43:38 PM UTC
  • Commit: f7ae2160cecd2209121757647d28e64ab8525202
  • Branch: refs/heads/release/8.0

…20.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23511.3 -> To Version 8.0.0-rtm.23520.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Oct 20, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Oct 20, 2023
@carlossanlop
Copy link
Member

@mmitche @lewing @steveisok @radical do we need to take this emsdk flow for GA? It's showing CI failures relevant to this, so I can't merge it.

@lewing
Copy link
Member

lewing commented Oct 21, 2023

I have not idea where that version number came from?

@lewing
Copy link
Member

lewing commented Oct 21, 2023

ok I think that should fix this one

@lewing
Copy link
Member

lewing commented Oct 22, 2023

@dotnet/source-build-internal ptal at the portable source build failure here

see dotnet/sdk#36340

@lewing
Copy link
Member

lewing commented Oct 22, 2023

it appears that the latest sdk has analysis failures

    Wasm.Build.Tests.TestAppScenarios.AppSettingsTests.LoadAppSettingsBasedOnApplicationEnvironment(applicationEnvironment: "Development") [FAIL]
       Expected 0 exit code but got 1: /root/helix/work/workitem/e/dotnet-latest/dotnet publish -bl:/root/helix/work/workitem/uploads/xharness-output/logs/AppSettingsTests_vb15h5zu_ylf/AppSettingsTests_vb15h5zu_ylf-publish.binlog -p:Configuration=Debug -nr:false /warnaserror -p:BlazorEnableCompression=false  
      Standard Output:
      [] MSBuild version 17.8.3+195e7f5a3 for .NET
      []   Determining projects to restore...
      []   Restored /root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/WasmBasicTestApp.csproj (in 1.12 sec).
      [] /root/helix/work/workitem/e/dotnet-latest/sdk/8.0.100-rtm.23520.38/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/WasmBasicTestApp.csproj]
      [] /root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/LazyLoadingTest.cs(15,20): error IL2026: Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [/root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/WasmBasicTestApp.csproj]
      []   WasmBasicTestApp -> /root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/bin/Debug/net8.0/WasmBasicTestApp.dll
      []   ** MicrosoftNetCoreAppRuntimePackDir : '/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/8.0.0-ci'
      []   Optimizing assemblies for size. This process might take a while.
      [] /root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/LazyLoadingTest.cs(15,9): Trim analysis error IL2026: LazyLoadingTest.Run(): Using member 'System.Text.Json.JsonSerializer.Serialize<TValue>(TValue, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [/root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/WasmBasicTestApp.csproj]
      []   WasmBasicTestApp -> /root/helix/work/workitem/e/wbt/AppSettingsTests_vb15h5zu_ylf/bin/Debug/net8.0/publish/
      
      Stack Trace:
        /_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(44,0): at Wasm.Build.Tests.CommandResult.EnsureExitCode(Int32 expectedExitCode, String messagePrefix, Boolean suppressOutput)
        /_/src/mono/wasm/Wasm.Build.Tests/Common/CommandResult.cs(28,0): at Wasm.Build.Tests.CommandResult.EnsureSuccessful(String messagePrefix, Boolean suppressOutput)
        /_/src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs(165,0): at Wasm.Build.Tests.BuildTestBase.BuildProjectWithoutAssert(String id, String config, BuildProjectOptions buildProjectOptions, String[] extraArgs)
        /_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(94,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorBuildInternal(String id, String config, Boolean publish, Boolean setWasmDevel, Boolean expectSuccess, String[] extraArgs)
        /_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(74,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorPublish(BlazorBuildOptions options, String[] extraArgs)
        /_/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/AppTestBase.cs(43,0): at Wasm.Build.Tests.TestAppScenarios.AppTestBase.PublishProject(String configuration)
        /_/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/AppSettingsTests.cs(29,0): at Wasm.Build.Tests.TestAppScenarios.AppSettingsTests.LoadAppSettingsBasedOnApplicationEnvironment(String applicationEnvironment)
        --- End of stack trace from previous location ---

and the one in global.json doesn't have the wasm template changes. These are the absolute worst kinds of painful changes to make at the last minute to break the build.

cc @mkArtakMSFT @SteveSandersonMS

@lewing lewing requested a review from radical as a code owner October 22, 2023 21:19
@lewing lewing merged commit 14a0bbc into release/8.0 Oct 23, 2023
183 of 186 checks passed
@lewing lewing deleted the darc-release/8.0-303af298-a10b-4c80-8b1f-7ff52ba3641e branch October 23, 2023 11:26
@carlossanlop
Copy link
Member

Thank you @lewing for the fixes!

lewing added a commit that referenced this pull request Oct 28, 2023
* [release/8.0] Stable branding for .NET 8 GA

* Handle an empty bandPreleaseVersion

* [release/8.0] Update dependencies from dotnet/emsdk (#93801)

* Update dependencies from https://github.com/dotnet/emsdk build 20231020.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23511.3 -> To Version 8.0.0-rtm.23520.2

* switch to the stable version now

* Update dependencies

* Also fix the trigger

* pin the wbt sdk to avoid the latest analizer nonsense

* Use source generation for the serializer

* Try to make sourcebuild happy

* Try again to make sourcebuild happy

* Use reflection and suppress trim analysis instead

This reverts commit 768b65b.

* Fix reverting too much

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>

* [release/8.0] Update APICompat settings under source build (#93865)

* Update APICompat settings under source build

* Update resolveContract.targets

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* Override InformationalVersion for NativeAOT corelib too

* [release/8.0] Improve performance of UnmanagedMemoryStream (#93812)

* Improve performance of UnmanagedMemoryStream

UnmanagedMemoryStream used Interlocked operations to update its state to prevent tearing of 64-bit values on 32-bit platforms. This pattern is expensive in general and it was found to be prohibitively expensive on recent hardware..

This change removes the expensive Interlocked operations and addresses
the tearing issues in alternative way:
- The _length field is converted to nuint that is guaranteed to be
  updated atomically.
- Writes to _length field are volatile to guaranteed the
  unininitialized memory cannot be read.
- The _position field remains long and it has a risk of tearing. It is
  not a problem since tearing of this field cannot lead to buffer
  overruns.

Fixes #93624

* Add comment

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Update dependencies from https://github.com/dotnet/emsdk build 20231023.2 (#93881)

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.0-rtm.23520.2 -> To Version 8.0.0-rtm.23523.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#93827)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20231021.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23519.5 -> To Version 1.0.0-prerelease.23521.3

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20231021.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23519.5 -> To Version 1.0.0-prerelease.23521.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [release/8.0][wasm] Fix perf pipeline runs (#93888)

* Remove --experimental-wasm-eh argument from the wasm_args used for wasm performance runs. (#93357)

(cherry picked from commit a770017)

* performance-setup.sh: Use `release/8.0` as the default channel

* performance-setup.ps1: use release/8.0 as the default channel

* Fix passing wasmArgs for bdn

---------

Co-authored-by: Parker Bibus <parkerbibus@microsoft.com>

* [release/8.0] Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. (#93935)

* Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution.

* Update src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>

* Address feedback

---------

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>

* [8.0] Update MsQuic (#93979)

* Try pinning the installer version to a 8.01xx sdk

* Target net8.0 in SatelliteAssemblyFromProjectRef

---------

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Parker Bibus <parkerbibus@microsoft.com>
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants