Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target Input Output as to not interfere with incremental. #901

Merged
merged 3 commits into from Jan 30, 2023

Conversation

yuehuang010
Copy link
Contributor

Fix a Target's Input Output as to not interfere with incremental detection.

@tmat
Copy link
Member

tmat commented Dec 31, 2022

Thanks for the fix. Would you mind updating the targets files of other providers (GitLab, etc.)?
Search the repo for Inputs="@(SourceRoot)" Outputs="|%(Identity)|" and update all of them.

@yuehuang010
Copy link
Contributor Author

@tmat, I am not able to locate this file on GitLab? Is GitHub the main hub for this project?

@rainersigwald
Copy link
Member

@yuehuang010 I think @tmat means the other copies of targets like this, of which there are several: https://github.com/search?q=repo%3Adotnet%2Fsourcelink%20%22%7C%25(Identity)%7C%22&type=code

@tmat
Copy link
Member

tmat commented Jan 30, 2023

@yuehuang010 Thanks!

@tmat tmat merged commit 4ad5e57 into dotnet:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants