Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small default font scaling corrections and optimizations. Fix #11037. #11206

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kirsan31
Copy link
Contributor

@kirsan31 kirsan31 commented Apr 12, 2024

Fixes #11037

Proposed changes

  • Сhange the default font only if it has really changed. Most of these problems already was solved in f36b0db.
  • Not use scaled default font for system fonts.
  • Not dispose user (external) fonts.

Customer Impact

  • Fewer font changing related actions and a bit less memory use.
  • Bug fixes.

Regression?

  • Yes

Risk

  • Minimal.

Test methodology

  • Existing unit tests.
  • New unit tests.
  • Manually with test app: DefFontTest.zip
Microsoft Reviewers: Open in CodeFlow

@kirsan31 kirsan31 requested a review from a team as a code owner April 12, 2024 10:01
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 60.43956% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 73.47415%. Comparing base (d9e9d93) to head (df91fcc).
Report is 46 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11206         +/-   ##
===================================================
+ Coverage   73.44664%   73.47415%   +0.02750%     
===================================================
  Files           3098        3101          +3     
  Lines         632225      632515        +290     
  Branches       46653       46706         +53     
===================================================
+ Hits          464348      464735        +387     
+ Misses        164485      164369        -116     
- Partials        3392        3411         +19     
Flag Coverage Δ
Debug 73.47415% <60.43956%> (+0.02750%) ⬆️
integration 18.35905% <0.00000%> (-0.00289%) ⬇️
production 46.96613% <44.18605%> (+0.05460%) ⬆️
test 94.98574% <75.00000%> (-0.00025%) ⬇️
unit 43.93455% <44.18605%> (+0.05695%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kirsan31 kirsan31 marked this pull request as draft April 12, 2024 11:13
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Apr 12, 2024
@kirsan31 kirsan31 marked this pull request as ready for review April 12, 2024 18:47
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Apr 12, 2024
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Button GDI (Font) leak
2 participants