Enable nullability in some ControlDesigner members #11285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11285 +/- ##
===================================================
+ Coverage 74.26878% 74.27201% +0.00322%
===================================================
Files 3025 3025
Lines 626861 626866 +5
Branches 46742 46743 +1
===================================================
+ Hits 465562 465586 +24
+ Misses 157959 157937 -22
- Partials 3340 3343 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
LGTM! |
SimonZhao888
previously approved these changes
Apr 28, 2024
Epica3055
reviewed
Apr 28, 2024
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
elachlan
added
the
📭 waiting-author-feedback
gpetrou
force-pushed
the
ControlDesigner
branch
from
96861aa
to
251c916
Compare
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
ricardobossan
added
the
waiting-review
lonitra
reviewed
May 3, 2024
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
lonitra
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
elachlan
added
the
waiting-review
LeafShi1
approved these changes
May 16, 2024
Tanya-Solyanik
approved these changes
May 22, 2024
Tanya-Solyanik
added
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow