Enable nullability in TransparentBehavior #11298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetrou
force-pushed
the
TransparentBehavior
branch
from
20695a8
to
3724fcd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11298 +/- ##
===================================================
+ Coverage 74.26878% 74.27277% +0.00398%
===================================================
Files 3025 3025
Lines 626861 626861
Branches 46742 46743 +1
===================================================
+ Hits 465562 465587 +25
+ Misses 157959 157931 -28
- Partials 3340 3343 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
elachlan
added
the
waiting-review
....Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.TransparentBehavior.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
📭 waiting-author-feedback
lonitra
reviewed
May 3, 2024
....Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.TransparentBehavior.cs
Outdated
Show resolved
Hide resolved
gpetrou
force-pushed
the
TransparentBehavior
branch
from
3724fcd
to
143bfa6
Compare
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
elachlan
added
the
waiting-review
LeafShi1
reviewed
May 16, 2024
| @@ -23,7 +21,7 @@ internal class TransparentBehavior : Behavior.Behavior | |||
| /// <summary> | |||
| /// Constructor that accepts the related ControlDesigner. | |||
| /// </summary> | |||
| internal TransparentBehavior(ControlDesigner designer) => _designer = designer; | |||
| internal TransparentBehavior(ControlDesigner designer) => _designer = designer.OrThrowIfNull(); | |||
There was a problem hiding this comment.
The designer here can be changed to be nullable ControlDesigner? designer because designer.OrThrowIfNull() is added, so that you can avoid changing the Public method in ControlBodyGlyph.cs
LeafShi1
added
📭 waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow