Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullability in DesignBindingValueUIHandler #11299

Merged
merged 2 commits into from May 24, 2024

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented May 1, 2024

Proposed changes

  • Enable nullability in DesignBindingValueUIHandler.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.27320%. Comparing base (74caf32) to head (5ab3e79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11299         +/-   ##
===================================================
+ Coverage   74.26878%   74.27320%   +0.00441%     
===================================================
  Files           3025        3025                 
  Lines         626861      626860          -1     
  Branches       46742       46742                 
===================================================
+ Hits          465562      465589         +27     
+ Misses        157959      157920         -39     
- Partials        3340        3351         +11     
Flag Coverage Δ
Debug 74.27320% <0.00000%> (+0.00441%) ⬆️
integration 17.98684% <0.00000%> (-0.01788%) ⬇️
production 47.00045% <0.00000%> (+0.00963%) ⬆️
test 96.99415% <ø> (ø)
unit 43.97265% <0.00000%> (+0.03701%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 1, 2024
Copy link
Contributor

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 3, 2024
@gpetrou gpetrou force-pushed the DesignBindingValueUIHandler branch from 3ed170f to 5ab3e79 Compare May 15, 2024 12:48
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 15, 2024
@gpetrou gpetrou requested a review from lonitra May 15, 2024 12:59
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 15, 2024
@Epica3055 Epica3055 removed the waiting-review This item is waiting on review by one or more members of team label May 24, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit b95d01b into dotnet:main May 24, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone May 24, 2024
@gpetrou gpetrou deleted the DesignBindingValueUIHandler branch May 25, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants