Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DomainUpDown #11331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented May 8, 2024

related #10453

Proposed changes

  • Add unit tests for DomainUpDown to test DownButton and UpButton methods: Verify the behavior of the DownButton and UpButton methods in the DomainUpDown class and how they change the SelectedIndex under different conditions
  • Add unit test for DomainUpDown to test ToString method: Test ToString method's output, ensuring it correctly reflects the state of the Items collection and the SelectedIndex.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 99.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.27404%. Comparing base (c4596e2) to head (30bd5c7).
Report is 47 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11331         +/-   ##
===================================================
+ Coverage   74.22320%   74.27404%   +0.05083%     
===================================================
  Files           3021        3025          +4     
  Lines         626156      626857        +701     
  Branches       46698       46742         +44     
===================================================
+ Hits          464753      465592        +839     
+ Misses        158006      157920         -86     
+ Partials        3397        3345         -52     
Flag Coverage Δ
Debug 74.27404% <99.42857%> (+0.05083%) ⬆️
integration 18.00578% <ø> (-0.26378%) ⬇️
production 47.00274% <ø> (+0.12263%) ⬆️
test 96.99412% <99.42857%> (-0.04459%) ⬇️
unit 43.97179% <ø> (+0.13783%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team labels May 9, 2024
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label May 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 10, 2024
@LeafShi1
Copy link
Member

LGTM! @lonitra Please review this PR.

@LeafShi1 LeafShi1 requested a review from lonitra May 11, 2024 06:45
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label May 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 16, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label May 16, 2024
Assert.True(control.CanRaiseEvents);
Assert.True(control.CausesValidation);
Assert.False(control.ChangingText);
Assert.Null(_sub.ActiveControl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fluent assertions.

@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📭 waiting-author-feedback The team requires more information from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants