Rooting serializable types for TrimTestBinaryDeserialization test #11342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11342 +/- ##
===================================================
+ Coverage 74.24289% 74.24401% +0.00112%
===================================================
Files 3022 3022
Lines 626297 626297
Branches 46702 46702
===================================================
+ Hits 464981 464988 +7
+ Misses 157921 157911 -10
- Partials 3395 3398 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonitra
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reliable way for the trimmer to statically reach types that are needed for resource serialization and deserialization. The current plan is to keep all relevant library types that are serializable to get resources working with trimmed WinForms applications.
The first iteration of this effort is to root all types in runtime and
windowsdesktop(withWindowsFormsprofile) assemblies that are serializable (except compiler generated types that are serializable). Additionally, there are couple of exceptions that are needed to be rooted for this test application to run in a trimmed mode; All ofmscorlibassembly is rooted and a couple of additional types in theSystem.Resources.Extensionsassembly (DeserializingResourceReader,RuntimeResourceSet).Future iterations should look at more simple WinForms applications with custom resources to identify a core set of library types that need to be keep for basic WinForms applications with custom resources to be trimmed.
Microsoft Reviewers: Open in CodeFlow