Visual Styles enabled or disabled, remove differentiation for border style in the left side of the row header when the style would have been set to Outset

[ricardobossan]

Fixes #5961

Proposed changes

• If DataGridView is RightToLeft, with either visual styles enabled or not, remove differentiation for border style in the left side of the row header when the style would have been set to Outset

Customer Impact

• Will be able to see left border of the row header when control is set to RightToLeft

Regression?

• No

Risk

• Minimal

Screenshots

Before

• Visual styles enabled

• Visual styles disabled

After

• Visual styles enabled

• Visual styles disabled

Test methodology

• Manual

Accessibility testing

• Accessibility insights

Test environment(s)

• dotnet 9.0.100-preview.3.24204.13

Microsoft Reviewers: Open in CodeFlow

[Tanya-Solyanik]

Please investigate the failing tests

[ricardobossan]

Please investigate the failing tests

@Tanya-Solyanik In my fix, I discovered that the transparency issue stems from the DataGridViewRow header's left border being set to Outset when RightToLeft is defined. By changing it to OutsetDouble, which matches the configuration when RightToLeft isn't chosen, the transparency problem is resolved.

However, this fix conflicts with existing tests, which expect the DataGridViewRow header's left border to be set to Outset. To ensure the integrity of the codebase, I'm considering modifying the tests to accommodate this fix.

I believe implementing this fix is crucial for resolving the reported issue and ensuring consistent behavior across different globalization settings. I'd appreciate your input on how best to proceed.

[Tanya-Solyanik]

However, this fix conflicts with existing tests, which expect the DataGridViewRow header's left border to be set to Outset. To ensure the integrity of the codebase, I'm considering modifying the tests to accommodate this fix.

I agree!

[Tanya-Solyanik]

In this image -

the column border is not visible between the column headers. Could you please open a new issue for that?

[LeafShi1]

In this image -

the column border is not visible between the column headers. Could you please open a new issue for that?

Using the same border style OutsetDouble here can resolve this issue

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridView.cs

Lines 506 to 513 in f2118b8

	if (RightToLeftInternal)
	{
	dgvabs.LeftInternal = DataGridViewAdvancedCellBorderStyle.Outset;
	}
	else
	{
	dgvabs.LeftInternal = DataGridViewAdvancedCellBorderStyle.OutsetDouble;
	}

[ricardobossan]

In this image -

the column border is not visible between the column headers. Could you please open a new issue for that?

@Tanya-Solyanik, Leaf's suggestion fixed it:

[Tanya-Solyanik]

@ricardobossan - please investigate unit test failures

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.28949%. Comparing base (f53f153) to head (9bda02d).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #11345         +/-   ##
===================================================
- Coverage   74.29395%   74.28949%   -0.00446%     
===================================================
  Files           3026        3026                 
  Lines         627152      627152                 
  Branches       46758       46758                 
===================================================
- Hits          465936      465908         -28     
- Misses        157863      157893         +30     
+ Partials        3353        3351          -2     

Flag	Coverage Δ
Debug	74.28949% <83.33333%> (-0.00446%)	⬇️
integration	17.98732% <0.00000%> (-0.00282%)	⬇️
production	47.02044% <50.00000%> (-0.00984%)	⬇️
test	96.98768% <100.00000%> (ø)
unit	43.97963% <50.00000%> (-0.03194%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[LeafShi1]

LGTM!

[Tanya-Solyanik]

                    dataGridViewAdvancedBorderStylePlaceholder.LeftInternal =
                        DataGridView.CellBorderStyle is DataGridViewCellBorderStyle.Raised or DataGridViewCellBorderStyle.RaisedVertical
                            ? DataGridViewAdvancedCellBorderStyle.OutsetPartial
                            : DataGridViewAdvancedCellBorderStyle.OutsetDouble;

[Tanya-Solyanik]

@Olina-Zhang - could you please test this change when you have time?