Add test coverage for LinkLabel.LinkCollection #11357
Open
+126
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11357 +/- ##
===================================================
+ Coverage 74.27085% 74.30362% +0.03276%
===================================================
Files 3025 3027 +2
Lines 626861 627135 +274
Branches 46742 46756 +14
===================================================
+ Hits 465575 465984 +409
+ Misses 157937 157809 -128
+ Partials 3349 3342 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
elachlan
added
the
waiting-review
Zheng-Li01
reviewed
May 13, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
Zheng-Li01
reviewed
May 13, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
|
For new added LinkCollectionTest.cs file, always named it to LinkCollectionTests.cs |
Zheng-Li01
added
📭 waiting-author-feedback
LeafShi1
reviewed
May 14, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTest.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTests.cs
Show resolved
Hide resolved
Tanya-Solyanik
added
📭 waiting-author-feedback
lonitra
previously approved these changes
May 22, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkCollectionTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10453
Proposed changes
Add unit tests for LinkLabel.LinkCollection to test its properties: IsReadOnly, IndexOf, IndexOfKey
Add unit tests for LinkLabel.LinkCollection to test its method: Add, Contains, ContainsKey, Remove, RemoveByKey
Customer Impact
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow