Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing styles #8699

Open
wants to merge 90 commits into
base: main
Choose a base branch
from

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Jan 18, 2024

Fixes #8698

Description

The changes define default styles of missing controls to Windows 11 Theme.
All the controls listed in the issue above has been added.

Regression

None

Testing

Local Build Pass

Microsoft Reviewers: Open in CodeFlow

singhashish-wpf and others added 30 commits December 7, 2023 11:41
Need to fix the public imports
harshit7962 and others added 22 commits January 4, 2024 15:40
Resolving Merge Conflicts

Removing IconProperty Reference
Adding Win11 Styles to ToggleButton, ListBox, ListBoxItem, Slider, ToolBar
Applying Win11 Styles to TabControl, Frame, Page
Adding Win11 Styles to TreeView and TreeViewItem
Import xaml styles in the integrated styles page
Moving ThemesDictionary and ControlsDictionary to parent namespace
Update ApplicationThemeManager.cs to use correct namespace
Add missing FontIcon and ImageIcon classes
* Added TextBox styles

Todo:
Clear button not showing up

* Added styles for PasswordBox

Todo:
Reveal button functionality not supported
@harshit7962 harshit7962 added this to the 9.0.0 milestone Jan 18, 2024
@harshit7962 harshit7962 requested a review from a team as a code owner January 18, 2024 07:36
@ghost ghost assigned harshit7962 Jan 18, 2024
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 18, 2024
@ghost ghost requested review from dipeshmsft and singhashish-wpf January 18, 2024 07:36
@harshit7962 harshit7962 changed the base branch from feature/win11theming/staging to main May 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Missing Control Styles in Windows 11 Themes
4 participants