Prefer use of interpolated strings in PresentationUI and ReachFramework #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
halgab
force-pushed
the
interpolated-string-presui
branch
from
d6cb976
to
999cfa6
Compare
halgab
force-pushed
the
interpolated-string-presui
branch
from
999cfa6
to
22c1e96
Compare
lindexi
reviewed
Jan 29, 2024
src/Microsoft.DotNet.Wpf/src/PresentationUI/MS/Internal/Documents/Application/DocumentStream.cs
Show resolved
Hide resolved
lindexi
reviewed
Jan 29, 2024
| sigStatus.ToString(), | ||
| height, | ||
| width); | ||
| string resourceName = $@"{sigStatus}_{height}x{width}"; |
There was a problem hiding this comment.
Missing InvariantCulture here.
There was a problem hiding this comment.
In the winforms repo, when doing such refactorings, a choice was made to ignore the invariant culture for int. I am no specialist but apparently it has no impact on integer formatting. I can put it back just for peace of mind
There was a problem hiding this comment.
Correct, as long as there is no format requested, the culture is not used (other than for negative sign, which shouldn't be an issue for width/height).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8519
Description
We replace as many manual string concatenations and string.Format with interpolated strings. This saves allocations in many instances, and makes for a more readable code.
Customer Impact
Less allocations
Regression
No
Testing
CI
Risk
Low. Most changes are automated using the IDE
Microsoft Reviewers: Open in CodeFlow