Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark theme visibility of Menu #8750

Open
wants to merge 1 commit into
base: feature/win11theming/staging
Choose a base branch
from

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Jan 30, 2024

Fixes #8742

Description

Windows 11 styling for menu does not have a provision to change the foreground based on theme. The default color of foreground is always black. Added the Brushes to support differential foreground of menu items based on system/application theme.

Regression

None

Testing

Local Build Pass

Risk

None

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 added this to the 9.0.0 milestone Jan 30, 2024
@harshit7962 harshit7962 requested a review from a team as a code owner January 30, 2024 08:44
@ghost ghost assigned harshit7962 Jan 30, 2024
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 30, 2024
@ghost ghost requested review from dipeshmsft and singhashish-wpf January 30, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant