Try fix GetHashCode implementation of the Thickness struct is broken for uniform length #8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
…for uniform length dotnet#8789
lindexi
force-pushed
the
t/lindexi/ThicknessHashCode
branch
from
9b8fade
to
736f6f5
Compare
|
Hash codes are explicitly not guaranteed to remain the same not only across framework versions but even across runs of the same application. This might be a better way to do this: |
|
Thank you @miloush and I will use your code. |
|
Apparently there are many other places that could switch to such a pattern. Should the scope of this PR be broadened? Or perhaps we could open a follow-up issue to review the |
|
@halgab At first, I must sure I do the right thing. I do not know change the GetHashCode behavior is the right thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8789
Description
I change the GetHashCode implementation of the Thickness struct. I use the HashCode to calculate the hash code of Thickness.
I'm not sure I'm doing the right thing.
Customer Impact
The GetHashCode of Thickness will be change
Regression
Testing
Just CI.
Risk
Normal. It's hard to evaluate. Because some logic that depends on the original behavior can break down.
Microsoft Reviewers: Open in CodeFlow