New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing ApplicationThemeManager in Windows 11 styles #8843
Open
harshit7962
wants to merge
15
commits into
dotnet:feature/win11theming/api/implementation
Choose a base branch
from
harshit7962:RemovingThemeManager
base: feature/win11theming/api/implementation
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Removing ApplicationThemeManager in Windows 11 styles #8843
harshit7962
wants to merge
15
commits into
dotnet:feature/win11theming/api/implementation
from
harshit7962:RemovingThemeManager
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Kumar Singh <singhashish@microsoft.com>
…s (Accent Colors, Background and System Theme)
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
February 26, 2024 10:58
dotnet-policy-service
bot
added
the
PR
metadata: Label to tag PRs, to facilitate with triage
label
Feb 26, 2024
harshit7962
changed the title
Removing theme manager
Removing ApplicationThemeManager in Windows 11 styles
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Theme and accent switching without ApplicationThemeManager.cs and SystemThemeWatcher.cs
Testing
Local Build Pass
Sample Application Testing
Microsoft Reviewers: Open in CodeFlow