Fixing A11y issues in combobox and scroll bar #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
dipeshmsft
changed the title
dipeshmsft
changed the title
anjali-wpf
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR fixes Accessibility issue which occurs due to improper naming of nested controls of scroll bar and editable combo box. Additionally, it fixes the one's with datepicker.
Customer Impact
Customers using accessibility tools will find it easier to navigate with the help of narrator and other tools.
Regression
None
Testing
Local Build Pass
Sample Application Testing
Risk
The name of scroll bar's repeat button is hard coded to up, down, left or right in the changes. Might need to verify if this conveys the message or do we need to be able to bind it based on its parent name.