Resolves the multiple emit from #280 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
force-pushed
the
fix-multiple-emit
branch
from
508c976
to
7da7497
Compare
palfrey
force-pushed
the
fix-multiple-emit
branch
2 times, most recently
from
09802bb
to
4338f34
Compare
dougmoscrop
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the multiple emit situation from #280. It needs the integration test work from #288 merging first. There is then the code in 4338f34 based on https://github.com/zoellner/serverless-http-pino-bug that demos the failure case followed by 4c9a15b to actually fix the problem.