Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): replace index with number #1592

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Apr 3, 2024

What:
Change index with number as highlightedIndex type.

Why:
Fixes #1590.

How:
Change the type.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b7f6765) to head (349a50d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1592   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1726      1726           
  Branches       518       518           
=========================================
  Hits          1726      1726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram merged commit 74ce0f5 into master Apr 3, 2024
2 checks passed
@silviuaavram silviuaavram deleted the types/fix-incorrect-index-type branch April 3, 2024 11:32
Copy link

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 9.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in typings/index.d.ts
2 participants