Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for customizable context menu & toolbar #2273

Merged
merged 3 commits into from
May 21, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented May 18, 2024

close #1343

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai force-pushed the feat/customizable-menu-item branch from da32c6f to edb9f74 Compare May 18, 2024 15:26
Copy link

github-actions bot commented May 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai force-pushed the feat/customizable-menu-item branch 2 times, most recently from e8d0df2 to 969bc22 Compare May 20, 2024 09:38
@jikkai jikkai marked this pull request as ready for review May 20, 2024 12:23
@jikkai jikkai requested review from wzhudev and Jocs as code owners May 20, 2024 12:23
@jikkai jikkai force-pushed the feat/customizable-menu-item branch from 969bc22 to e08bd19 Compare May 20, 2024 12:23
@jikkai jikkai force-pushed the feat/customizable-menu-item branch from e08bd19 to 013c622 Compare May 20, 2024 12:24
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 3.09811% with 563 lines in your changes are missing coverage. Please review.

Project coverage is 30.20%. Comparing base (43e57fa) to head (1a84813).

Files Patch % Lines
packages/sheets-ui/src/controllers/menu/menu.ts 5.88% 144 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 51 Missing ⚠️
packages/sheets-numfmt/src/menu/menu.ts 0.00% 50 Missing ⚠️
...-conditional-formatting-ui/src/menu/manage-rule.ts 0.00% 39 Missing ⚠️
...ages/sheets-ui/src/controllers/menu/insert.menu.ts 0.00% 32 Missing ⚠️
...kages/sheets-ui/src/controllers/menu/sheet.menu.ts 0.00% 24 Missing ⚠️
...ages/sheets-ui/src/controllers/menu/delete.menu.ts 0.00% 20 Missing ⚠️
...kages/sheets-ui/src/controllers/menu/clear.menu.ts 0.00% 16 Missing ⚠️
packages/ui/src/common/menu-merge-configs.ts 0.00% 16 Missing ⚠️
...kages/sheets-ui/src/controllers/menu/merge.menu.ts 0.00% 15 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2273      +/-   ##
==========================================
- Coverage   30.32%   30.20%   -0.12%     
==========================================
  Files        1412     1413       +1     
  Lines       72180    72491     +311     
  Branches    15123    15155      +32     
==========================================
+ Hits        21885    21898      +13     
- Misses      50295    50593     +298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the feat/customizable-menu-item branch from 9541880 to a91f2ae Compare May 21, 2024 06:56
@jikkai jikkai merged commit b253997 into dev May 21, 2024
9 checks passed
@jikkai jikkai deleted the feat/customizable-menu-item branch May 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] custom setting for context menu
2 participants