Add --with-sdl-net option to enable network builds #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamlayers
reviewed
Dec 5, 2022
| AS_IF([test "x$with_sdl_net" != "xno"],[ | ||
| AS_IF([test "x$with_sdl_net" = "xyes"], | ||
| [CXXFLAGS="$CXXFLAGS -s USE_SDL_NET=2"], | ||
| [LIBS="$LIBS -L$with_sdl_net/build/.libs/ -lSDL2_net" |
There was a problem hiding this comment.
Why -L$with_sdl_net/build/.libs/? The SDL_net library provided by Emscripten should link with only -lSDL2_net when using em++ -s USE_SDL=2 -s USE_SDL_NET=2
|
It should now be possible to build with SDL_net using I've cherry-picked df3b102. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
./configure --with-sdl-netoption to enable networking support with Emscripten builds