Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #15 from manwaring/master #15

Merged
merged 2 commits into from Feb 2, 2020

Conversation

manwaring
Copy link
Contributor

@manwaring manwaring commented Feb 2, 2020

Serverless Framework 1.61.2 introduced a breaking change to the way the AWS SDK is called via the framework. See this issue for more details: serverless/serverless#7225

The impact on this library is that it doesn't work at all anymore with 1.61.2. The following is printed in the terminal:

Serverless: Cannot count: Missing region in config!

Additional bash output context:

Service Information
service: redacted
stage: prod
region: us-east-1
stack: redacted-prod
resources: 17
api keys:
  None
endpoints:
  None
functions:
  invalidate-cache: redacted-prod-invalidate-cache
  bucketEvent: redacted-prod-bucketEvent
layers:
  None
Serverless: Cannot count: Missing region in config!
Serverless: Run the "serverless" command to setup monitoring, troubleshooting and testing.

This PR adds the region config to the credentials to fix the issue, following the example in another plugin: amplify-education/serverless-domain-manager#307

I tested the changes locally by editing the library directly in node_modules and was able to verify that the library works correctly afterwards.

@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          35     36    +1     
  Branches        5      5           
=====================================
+ Hits           35     36    +1
Impacted Files Coverage Δ
index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a09a3...248ba83. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@drexler
Copy link
Owner

drexler commented Feb 2, 2020

@manwaring Thanks for the PR. For the update to PR, if you can switch to conventional commit-style that will take care of the versioning & changelog updates.
Example commit: fix: handle breaking change in sls framework 1.61.2

@drexler
Copy link
Owner

drexler commented Feb 2, 2020

@manwaring 👍

@drexler drexler changed the title fix breaking change in sls framework 1.61.2 Merge pull request #15 from manwaring/master Feb 2, 2020
@drexler drexler merged commit 3ede297 into drexler:master Feb 2, 2020
@drexler
Copy link
Owner

drexler commented Feb 2, 2020

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants