Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not available step logs #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

say5
Copy link

@say5 say5 commented Mar 11, 2024

In many cases step logs are not available in the UI. I have a theory that this relates to the fact that logs being requested too early, when container isn't started yet. There was an attempt to fix it, unfortunately it's not great. Sometimes it can take minutes for container to start. So instead of just delay before get logs we need to wait until container is started. Problem is - in Kubernetes after placeholder image changed to actual image container status is still running, proposed solution - we can watch at restartCount, looks like this metric changes after container has started. In our case this works perfectly.

say5 and others added 5 commits March 6, 2024 13:06
* chore: ops-9634 docker pipelines

* fix

* fix

* debug: debug

* retry

* retry fix

* arm64

* fix

* fix

* fix
* chore: wait for restart

* check for placeholder

* debug

* check every 5 mins

* undo fetchLogs

* fix: restart

* cleanup
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants