fixes #1 Add filed "type" for host path volume settings. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
By the way, I found the runner can support claim mount. However the feature is not described in the document. It will be nice to add it, many user want this in their CI/CD. |
|
Bump. Was confused why this didn't work, as being able to mount Docker socket is key to our use case. |
|
@bradrydzewski are there any outstanding issues with this PR? We currently have to vendor the project in order to apply this patch, which is a bit annoying. Using socket type is much better than any alternate solution for running Docker inside build containers. Happy to help here in any way. Tyty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use drone-runner-kubernetes, I found it only support
DirectoryOrCreatetype of host path volume, so I made this pull request to fix this. In many CI/CD cases, users may use other types to mount host path (like /var/run/docker.sock), it is hard to use if this runner can only mount a directory.