add PR 37 & PriorityClassName param #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the fix proposed in #37 to tag v1.0.0-beta.6
We have applied this fix to the tag because we find that the commits to
mastersince v1.0.0-beta.6 have introduced a bug in which resource settings applied at the pipeline level cause step-level resource settings to be ignored.Additionally, whilst we find that this PR fixes the issue of steps being stuck in running status even when the underlying container has completed, we find that it introduces another bug in which pipeline timeout settings are not respected.
This code produces behaviour in which if a step's duration causes the pipeline to exceed the timeout, the step is allowed to run to completion however no subsequent steps are run. By contrast, prior to this change, the whole pipeline was immediately terminated once the timeout was reached. This new behaviour produces a consequence of pipelines running indefinitely if particular steps do not complete.
Additionally, this PR adds a new feature in which pipeline pods can have their default
priorityClassconfigured by editing the runner's policy file.