Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test placeholder based on complete image. #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrouly
Copy link

@jrouly jrouly commented Jun 6, 2023

Took me a long time to figure out what was going on here.

I have custom cloner and placeholder images. They are hosted on a private registry in the same image repository and differentiated by tags. For example,

example.com/drone:git
example.com/drone:placeholder

These images are multiplatform images based on drone/git and drone/placeholder.

Because these images differ only in tag, the check image.Match (which explicitly ignores tags) is detecting the cloner step as having completed with the placeholder image -- i.e., the placeholder failed(!). This is detected as a step/framework error and the stage aborts.

I really have no idea why we would want to exclude tag here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants