Unify registry+repo behavior between plugins #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when trying to do a bulk change of our repositories to use the upstreaam
plugins/kaniko{,-ecr,-gcr}
-- they don't behave the same when you passSpecifically:
index.docker.io/bar
example.com/bar
(which is the behavior I would expect)So, with the current state, our non-ECR / non-GCR images have to repeat the registry in the settings block, and they are inconsistent with the internal one.
This PR allows use of either the "compatible" setting block like
or the previously required
with the same results of trying to push to
example.com/bar
This change attempts to retain backward compatibility to avoid breaking anyone.