Upgraded golang version #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham149
reviewed
Mar 10, 2022
docker/docker/Dockerfile.linux.amd64
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM gcr.io/kaniko-project/executor:v1.6.0 | |||
| FROM gcr.io/kaniko-project/executor:v1.8.0 | |||
There was a problem hiding this comment.
@aman-harness Can you test whether updated kaniko works for gcr, ecr & dockerhub? Last time there was an issue in updated kaniko version due to which we have to revert the change.
There was a problem hiding this comment.
[](url
)
I ahve tested it for all 3 of them and it was working fine
This reverts commit 1536f84.
shubham149
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.